Conversation
ildyria
added
the
Review: easy
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
tinohager
reviewed
Jun 4, 2025
ildyria
commented
Jun 4, 2025
JasonMillward
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to enable or disable the slideshow functionality in the gallery application. The changes include backend updates to store and retrieve the slideshow setting, as well as frontend modifications to respect this setting when rendering UI components or handling user interactions.
Backend Changes:
InitConfigclass updates: Added a new propertyis_slideshow_enabledto theInitConfigclass and initialized it in the constructor by fetching the value from the configuration. (app/Http/Resources/GalleryConfigs/InitConfig.php, [1] [2]slideshow_enabledconfiguration with default value1(enabled). (database/migrations/2025_05_29_174832_add_slideshow_enabled.php, database/migrations/2025_05_29_174832_add_slideshow_enabled.phpR1-R32)Frontend Changes:
AlbumHero.vueandPhotoHeader.vueto conditionally display slideshow-related buttons based on theis_slideshow_enabledsetting. (resources/js/components/gallery/albumModule/AlbumHero.vue, [1] [2];resources/js/components/headers/PhotoHeader.vue, [3] [4]is_slideshow_enabledto the Lychee state store and ensured it is updated during initialization. (resources/js/stores/LycheeState.ts, [1] [2]spacekey) to respect theis_slideshow_enabledsetting. (resources/js/views/gallery-panels/Album.vue, [1] [2]